Skip to content

Fixing ADC-> e- calibration in blip data processing#939

Open
Jjm321814 wants to merge 1 commit into
developfrom
BugFix/BlipADCScale
Open

Fixing ADC-> e- calibration in blip data processing#939
Jjm321814 wants to merge 1 commit into
developfrom
BugFix/BlipADCScale

Conversation

@Jjm321814

@Jjm321814 Jjm321814 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

reco2_data did not update the blipreco or blipana ADC->e- calibration constant, and just applied the MC value.
With this PR the data is scaled by the appropriate calibration data.
This should improve data-MC agreement by ~4% and will not impact production or performance in any meaningful way.

@Jjm321814 Jjm321814 self-assigned this Jul 6, 2026
@Jjm321814 Jjm321814 added the reco1/reco2 Reconstruction label Jul 6, 2026
@Jjm321814

Jjm321814 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

The caloAlg parameters for MC and Data should be the following
MC

CaloAlg: {
               CalAmpConstants: [
                  5.88726e-4,
                  5.88726e-4,
                  1.18998e-3
               ]
               CalAreaConstants: [
                  2.052e-2,
                  2.044e-2,
                  2.019e-2
               ]

Data

CaloAlg: {
               CalAmpConstants: [
                  5.88726e-4,
                  5.88726e-4,
                  1.18998e-3
               ]
               CalAreaConstants: [
                  2.172e-2,
                  2.15e-2,
                  2.103e-2
               ]

Prior to this PR fhicl-dump reco2_data.fcl would display the MC values.
After this PR it displays the expected data values.
Similarly fhicl-dump standard_reco2_sbnd.fcl returns the MC values.

Since fhicl-dump still runs without issue and the parameters seem appropriately updated, no further validations were performed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miquelnebot miquelnebot Awaiting requested review from miquelnebot
@justinjmueller justinjmueller Awaiting requested review from justinjmueller

At least 1 approving review is required to merge this pull request.

Assignees

@Jjm321814 Jjm321814

Labels

reco1/reco2 Reconstruction

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Jjm321814